Strip Symbols From Linux & Mac #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a before and after test so there's no mistake of leaving symbols in, and to test the effectiveness of the strip. The default test symbol is processBlock, but it's a good idea to also check any sensitive symbols (eg. privateKey).
I wasn't able to figure out the best way to do this on Windows. On Linux and Mac, it's unreliable to use compiler flags. It's more verbose than the other jobs, I leave it to you to decide how informative it is.
If anyone can figure out the windows strip and symbol export, that would be dandy.
This also serves as a building block towards #121 (comment)