Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop support for node v10 and v12 #5355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Meir017
Copy link

@Meir017 Meir017 commented Aug 1, 2022

Description:

BREAKING CHANGE:

  • dropping support for node v10
  • dropping support for node v12

Related issue (if exists):

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kwonoj
Copy link
Member

kwonoj commented Aug 1, 2022

This is technically considered as breaking change, which should aim v2 major breaking for @swc/core if that's the case.

@Meir017
Copy link
Author

Meir017 commented Aug 1, 2022

@kwonoj do I need to make additional changes for v2?

@kwonoj
Copy link
Member

kwonoj commented Aug 1, 2022

We do not have release branches for v2 yet. In short, this PR cannot go to current main branch.

@Meir017 Meir017 requested a review from a team as a code owner April 29, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for node v10 and v12
5 participants