Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix mobile rendering detail and adding from and to links #73

Merged
merged 8 commits into from
Aug 22, 2023

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Aug 16, 2023

Description

  • Fix some issues with mobile rendering
  • add explorer links for from and to fields

Related Issue Or Context

Closes: #61 #40

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola requested a review from FSM1 August 16, 2023 14:46
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c3eaba5
Status: ✅  Deploy successful!
Preview URL: https://a42d83a2.explorer-ui-qxq.pages.dev
Branch Preview URL: https://feat-mobile-rendering-detail.explorer-ui-qxq.pages.dev

View logs

@MakMuftic MakMuftic self-requested a review August 22, 2023 12:38
@wainola wainola merged commit d257e11 into main Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mobile rendering for detail view
2 participants