Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: similar interface for substrate and evm transfers #570

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

saadahmsiddiqui
Copy link
Member

Description

Change destinationAddress to recipientAddress in substrate transfers as well as amount to transferAmount to match evm

How Has This Been Tested? Testing details.

Updated existing unit tests

Checklist:

  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Lykhoyda
Lykhoyda previously approved these changes Oct 29, 2024
@saadahmsiddiqui saadahmsiddiqui merged commit 8cc52e0 into main Nov 11, 2024
3 checks passed
@saadahmsiddiqui saadahmsiddiqui deleted the fix/same-fungible-interface-substrate-and-evm branch November 11, 2024 16:34
saadahmsiddiqui pushed a commit that referenced this pull request Nov 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.0.5](substrate-v1.0.4...substrate-v1.0.5)
(2024-11-11)


### Bug Fixes

* similar interface for substrate and evm transfers
([#570](#570))
([8cc52e0](8cc52e0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
saadahmsiddiqui pushed a commit that referenced this pull request Nov 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.2](utils-v1.3.1...utils-v1.3.2)
(2024-11-11)


### Bug Fixes

* similar interface for substrate and evm transfers
([#570](#570))
([8cc52e0](8cc52e0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants