Skip to content

Commit

Permalink
fix(tests): tests are only runs with python3.13 (#16)
Browse files Browse the repository at this point in the history
Python3.9 is removed, the aclosing function is added in version 3.10 : https://docs.python.org/3/library/contextlib.html#contextlib.aclosing
  • Loading branch information
sylvainmouquet authored Oct 9, 2024
1 parent 75502ba commit ecd56f7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .github/actions/test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,5 @@ runs:
- name: Run tests
run: make test
shell: bash
env:
PYTHON_VERSION: ${{ matrix.python-version }}
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: macos-latest
strategy:
matrix:
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.10', '3.11', '3.12', '3.13']
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -27,7 +27,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.10', '3.11', '3.12', '3.13']
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -38,7 +38,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.10', '3.11', '3.12', '3.13']
steps:
- uses: actions/checkout@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ install-local:
test:
@echo "Modified arguments: $(new_args)"
@if [ -z "$(COMMAND_ARGS)" ]; then \
uv run pytest -v --log-cli-level=INFO; \
uv run --python $${PYTHON_VERSION:-3.13} pytest -v --log-cli-level=INFO; \
else \
uv run pytest -v --log-cli-level=INFO $(new_args); \
uv run --python $${PYTHON_VERSION:-3.13} pytest -v --log-cli-level=INFO $(new_args); \
fi

# Lint command
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ classifiers = [
"License :: OSI Approved :: MIT License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Expand Down

0 comments on commit ecd56f7

Please sign in to comment.