API Strongly type return types #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/7/field-validators
branch
from
395c072
to
31f2df4
Compare
10 tasks
GuySartorelli
requested changes
Oct 22, 2024
emteknetnz
force-pushed
the
pulls/7/field-validators
branch
from
31f2df4
to
6df3e54
Compare
|
In the interest of getting things merged I'll allow these changes. While I still don't think they're correct, they also don't seem harmful except in that they allow continued poor practice by developers. |
GuySartorelli
approved these changes
Oct 29, 2024
emteknetnz
force-pushed
the
pulls/7/field-validators
branch
from
6df3e54
to
5aab70f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11403