Talon v0.4 support: port from resource.open to resource.watch & initial talon-list conversions #1239

knausj85 · 2023-07-24T20:28:56Z

Splitting #1234 into a few pull requests for convenience. This is not fully vetted yet, opening a draft for convenience and initial discussion.

port from resource.open to resource.watch (Talon v0.4) (merge in port from resource.open to resource.watch (Talon v0.4) #1199)
Convert many lists to .talon-list to jumpstart the process / discussion. I did not attempt to convert them all, just the highest priority targets and a few interesting ones for discussion. We need some sort of migration plan, as I would like to move away from CSVs wherever possible.
Also adds support for keypad keys, as it wasn't worth the effort to separate into a separate pull request

todo:

Fix unit tests for create spoken forms
Create a CSV to .talon-list converter for targeted conversions
Verify emacs functionality

Questions:

Should CSVs migrated to talon-lists migrated continue to live in Settings?
do we want to auto regenerate a talon list if it's deleted as was done for the CSVs?
is there a 'good' way to migrate targeted lists that exist only in python without breaking every customization?

for more information, see https://pre-commit.ci

knausj85 · 2023-07-24T20:35:34Z

core/keys/punctuation.talon-list

+-
+`: `


This can be moved to a dragon specific punctuation list.

core/keys/function_key.talon-list

knausj85 · 2023-07-24T20:45:53Z

core/keys/keys.py

+default_digits = "zero one two three four five six seven eight nine".split(" ")
+numbers = [str(i) for i in range(10)]
+default_f_digits = (
+    "one two three four five six seven eight nine ten eleven twelve".split(" ")


Merge error, can be removed.

knausj85 · 2023-07-24T20:47:14Z

plugin/text_navigation/navigation_target_name.talon-list

+#todo: if we wanted to convert this
+# we'd probably want to rework the list to have hard-coded strings
+# like e.g. BRACES on the right side.
+# list: user.navigation_target_name
+# -


I'm leaving a note here for discussion purposes. I don't think this should be converted as is.

lunixbochs · 2023-07-24T20:48:48Z

core/keys/arrow_key.talon-list

+down: down
+left: left
+right: right
+up: up


You can just do up instead of up: up in all of these identity mapped lists. With up: up it's actually kind of confusing which side to edit too.

It's arguably a bit more convenient for those that may customize to keep up: up though.

This is a similar problem to eg https://github.com/talonhub/community/blob/7b09a4a789ed1dc380865d2840a5abda9f65af25/core/windows_and_tabs/window_snap_positions.talon-list

where we may be better off with something more obviously not a spoken form on the right side.

I think up: up is not more convenient at all, because it's not obvious which side to edit when the sides are symmetrical. I think using a non spoken form on the right hand side is also bad (in the case of key mappings), because the right hand side is a key name. You shouldn't map those to something else.

up on a line by itself should be fine. It's easy enough to teach people how to work with these files I think. We're still much better off than the "simple key names" in Python where you had to move the key to a different list if you wanted to remap it.

If the file contains:

list: user.arrow_key - up down left right

I want to remove "up" and add "shoop" mapped to up. I need to know what the existing lines in the .talon-list mean, and I need to know how to add a line. I need to know this regardless of whether the file contains up: up or just up.

-up +shoop: up

Anyway. Don't do up: up. Not worth bike shedding.

knausj85 · 2023-07-24T21:21:43Z

plugin/talon_helpers/talon_helpers.talon

@@ -36,6 +37,7 @@ talon dump context:
    user.talon_action_find("{user.talon_actions}")
 ^talon debug list {user.talon_lists}$: user.talon_debug_list(talon_lists)
 ^talon copy list {user.talon_lists}$: user.talon_copy_list(talon_lists)
+^talon convert list {user.talon_lists}$: user.talon_convert_list(user.talon_lists)


Probably remove this

for more information, see https://pre-commit.ci

core/text/prose_snippets.talon-list

auscompgeek · 2023-07-26T11:31:51Z

core/user_settings.py

+    return decorator
+
+
+# NOTE: this is deprecated, use @track_csv_list instead.


TODO: raise a Deprecation/FutureWarning?

auscompgeek · 2023-07-26T11:36:05Z

test/stubs/talon/__init__.py

@@ -184,6 +184,9 @@ class Resource:
    def open(self, path: str, mode: str = "r"):
        return open(path, mode, encoding="utf-8")

+    def watch(self, path: str):
+        pass


Shouldn't this return an identity function?

Suggested change

pass

return lambda f: f

Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>

knausj85 and others added 5 commits July 24, 2023 13:48

initial conversions

c1456e9

work

76ba15f

merge in #1199

6b80be6

Update keys.py

12d6bbb

[pre-commit.ci] auto fixes from pre-commit.com hooks

5a92278

for more information, see https://pre-commit.ci

knausj85 commented Jul 24, 2023

View reviewed changes

core/keys/punctuation.talon-list

Comment on lines +2 to +3

-

`: `

Copy link

Member Author

knausj85 Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved to a dragon specific punctuation list.

knausj85 commented Jul 24, 2023

View reviewed changes

core/keys/function_key.talon-list Show resolved Hide resolved

knausj85 commented Jul 24, 2023

View reviewed changes

lunixbochs reviewed Jul 24, 2023

View reviewed changes

knausj85 mentioned this pull request Jul 24, 2023

port from resource.open to resource.watch (Talon v0.4) #1199

Closed

knausj85 commented Jul 24, 2023

View reviewed changes

knausj85 and others added 2 commits July 24, 2023 19:11

Update __init__.py

af1d9c7

[pre-commit.ci] auto fixes from pre-commit.com hooks

7b09a4a

for more information, see https://pre-commit.ci

auscompgeek reviewed Jul 26, 2023

View reviewed changes

Update core/text/prose_snippets.talon-list

80de24c

Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>

saidelike mentioned this pull request Sep 30, 2023

porting the .csv files to .talon-list files #1268

Merged

knausj85 closed this Feb 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Talon v0.4 support: port from resource.open to resource.watch & initial talon-list conversions #1239

Talon v0.4 support: port from resource.open to resource.watch & initial talon-list conversions #1239

knausj85 commented Jul 24, 2023 •

edited

Loading

knausj85 Jul 24, 2023

knausj85 Jul 24, 2023

knausj85 Jul 24, 2023

lunixbochs Jul 24, 2023

knausj85 Jul 25, 2023

lunixbochs Jul 25, 2023 •

edited

Loading

knausj85 Jul 24, 2023

auscompgeek Jul 26, 2023

auscompgeek Jul 26, 2023

		return decorator


		# NOTE: this is deprecated, use @track_csv_list instead.

Talon v0.4 support: port from resource.open to resource.watch & initial talon-list conversions #1239

Talon v0.4 support: port from resource.open to resource.watch & initial talon-list conversions #1239

Conversation

knausj85 commented Jul 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lunixbochs Jul 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

knausj85 commented Jul 24, 2023 •

edited

Loading

lunixbochs Jul 25, 2023 •

edited

Loading