-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements "find" tag for webbrowsers #1405
Implements "find" tag for webbrowsers #1405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there are any shortcuts that are general enough for all browsers. The shortcuts are gonna be different depending on platform and application and should be defined in the application context. We should also not use user.find
when there is edit.find
. We should definitely just migrate everything to the edit actions.
Here is a pull request to replace |
Alright, happy to implement those changes. |
Most of the work is already done in #1499 |
From a quick test on a number of browsers on both windows and macOS, I believe all we need to do here is enable the tag in browser.talon. Re-requested review for sanity |
The goal of this PR is to add basic search functionality for webbrowsers based on the new "find" tag from the other already merged PR 1404. The code has been tested on windows, but not on mac or Linux.
I left a commented out version for
def find()
in the PR as this alternative version may be more robust.I checked and tested that the implemented keyboard actions work in windows for chrome, firefox, opera, edge, and brave.