jetbrains: Clean up and fix logging and error handling #1445
Conversation
auscompgeek
changed the title
| for cmd in command_list: | ||
| if cmd: | ||
| send_idea_command(cmd.strip()) | ||
| actions.sleep(0.1) |
There was a problem hiding this comment.
Doesn't have to be done in this PR but we should really see if this can be removed. It makes the running of multiple actions like idea_grab() unnecessarily slower/jankier.
(I ran with it removed for many months, but I've since diverged from community enough that it'd be good for someone else to test too)
apps/jetbrains/jetbrains.py
Outdated
| actions.sleep(0.1) | ||
| except Exception as e: | ||
| app.notify(e) | ||
| raise e |
There was a problem hiding this comment.
I was going to recommend just raise, but it looks like in Python 3 this doesn't actually remove any of the context, waited under Python 2? https://stackoverflow.com/a/45986945/303833
|
#1411 is there and does something similar. which of the two do you prefer @auscompgeek ? |
|
I don't use jetbrains, but it looks like this one is ready to be merged @phillco @auscompgeek ? Trying to close out some older PRs Maybe the tiebreak between this and #1411 is that this one is already approved :) |
extendCommandsvariable