Extending the pages tag #1455
Extending the pages tag #1455
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
fidgetingbits
force-pushed
the
pages-tag-extension
branch
from
56cd6db
to
27926fb
Compare
|
We had a discussion about this in the community backlog session and we think we prefer |
…knausj_talon into pages-tag-extension
…ruening/knausj_talon into pages-tag-extension" This reverts commit cb2911b, reversing changes made to 56cd6db.
|
I renamed however, the general, empty definition of these functions with only the docstring is now being done in pages.py. Is there a better place to do this? |
|
Yeah we should probably move those somewhere else. Personally I have a separate navigation file for them. |
|
A new navigation tag? That then forms a subtag of the pages tag? This would be a very small tag... As an alternative, just create the empty functions in the core directory (without a tag). And just call these functions in the pages tag/wherever? |
|
Doesn't necessarily need the tag, but I don't think we should put those actions in pages. Putting a new python file directly in the core directory sounds reasonable. |
There was a problem hiding this comment.
Could you please take a look at @AndreasArvidsson 's request? Thanks!
|
Will have time in about 10 days |
|
@maxbruening I will be happy to do them move myself? It's just moving those two actions out of the pages file. |
|
I made a separate pull request where I implement that go back and go forward actions as well as actually using them in different applications. Once this is merged I will rebase this pull request. |
|
The navigation refactoring is now on main. I'm happy, but since I've made changes I would like another developer to take a look at it before we merge. |
knausj85
dismissed
nriley’s stale review
navigation tag has been implemented.
This pull request aims to extend the pages tag and applies the new commands for foxit, Sumatra, and the adobe pdf reader.
Currently, the pages tag seems to be used by document viewers, mostly pdf readers. This type of software typically has the ability to rotate pages, and also to go back and forth when users click on an internal link. this pull request adds these functions to the pages tag.