Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unprefixed numbers command #1576

Merged
merged 5 commits into from
Oct 26, 2024
Merged

Remove unprefixed numbers command #1576

merged 5 commits into from
Oct 26, 2024

Conversation

AndreasArvidsson
Copy link
Collaborator

This is a source of misrecognitions for new users. We have now had the deprecation message for nine months so I think it's fine to remove this.

@jaresty
Copy link
Contributor

jaresty commented Oct 16, 2024

Just to double check my understanding: after this change it will mean that everyone will need to say 'numb' in order to input a number?

@AndreasArvidsson
Copy link
Collaborator Author

Just to double check my understanding: after this change it will mean that everyone will need to say 'numb' in order to input a number?

Yes unless they change the command.

@jaresty
Copy link
Contributor

jaresty commented Oct 16, 2024

Thanks for the clarification. This is how I'm using it, so seems fine to me.

@nriley
Copy link
Collaborator

nriley commented Oct 19, 2024

We have frequently had questions in Slack asking how to allow unprefixed numbers and stop displaying the notification. We decided on the community backlog session to implement a user.unprefixed_numbers tag instead and the default will then become prefixed numbers without any warning.

Copy link
Collaborator

@nriley nriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@AndreasArvidsson
Copy link
Collaborator Author

Fixed

@@ -177,7 +177,7 @@ def split_list(value, l: list) -> Iterator:
number_small_map = {n: i for i, n in enumerate(number_small_list)}

mod.list("number_small", desc="List of small numbers")
mod.tag("prefixed_numbers", desc="Require prefix when saying a number")
mod.tag("unprefixed_numbers", desc="Dont require prefix when saying a number")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick: should numbers.talon be disabled when this tag is active?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I don't know if people want both active or only one of them?

Copy link
Collaborator

@nriley nriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is good for a first attempt, addressing most of the issues we have heard about in slack, and we can always change things if there are further complaints.

@nriley nriley merged commit c5b38ae into main Oct 26, 2024
2 checks passed
@nriley nriley deleted the removeUnprefixedNumbers branch October 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants