-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unprefixed numbers command #1576
Conversation
Just to double check my understanding: after this change it will mean that everyone will need to say 'numb' in order to input a number? |
Yes unless they change the command. |
Thanks for the clarification. This is how I'm using it, so seems fine to me. |
We have frequently had questions in Slack asking how to allow unprefixed numbers and stop displaying the notification. We decided on the community backlog session to implement a user.unprefixed_numbers tag instead and the default will then become prefixed numbers without any warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
Fixed |
@@ -177,7 +177,7 @@ def split_list(value, l: list) -> Iterator: | |||
number_small_map = {n: i for i, n in enumerate(number_small_list)} | |||
|
|||
mod.list("number_small", desc="List of small numbers") | |||
mod.tag("prefixed_numbers", desc="Require prefix when saying a number") | |||
mod.tag("unprefixed_numbers", desc="Dont require prefix when saying a number") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick: should numbers.talon be disabled when this tag is active?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I don't know if people want both active or only one of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is good for a first attempt, addressing most of the issues we have heard about in slack, and we can always change things if there are further complaints.
This is a source of misrecognitions for new users. We have now had the deprecation message for nine months so I think it's fine to remove this.