Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link map image #128

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

escapedcat
Copy link
Contributor

Does this PR address a related issue?
No

A description of the changes proposed in the pull request
I tend to click on the map image to go to the map on desktop.
Maybe I'm the only one. Just wanted to propose it.

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for btcmap ready!

Name Link
🔨 Latest commit a8fabf6
🔍 Latest deploy log https://app.netlify.com/sites/btcmap/deploys/65d4a02a95d29a00084f264d
😎 Deploy Preview https://deploy-preview-128--btcmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 55 (🟢 up 1 from production)
Accessibility: 84 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 100 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@secondl1ght secondl1ght self-requested a review February 20, 2024 14:30
@secondl1ght
Copy link
Member

Hey @escapedcat good to hear from you. :) I don't see an issue with this, the only thing might be that we would not want to have this a link on mobile to avoid users accidentally clicking on it while scrolling the page. But I think it's fine, and we can make that update later if anyone complains about this. Thanks for the PR!

@secondl1ght secondl1ght merged commit ddc1338 into teambtcmap:main Feb 20, 2024
7 checks passed
@escapedcat escapedcat deleted the feat/map-link branch February 20, 2024 14:39
@escapedcat
Copy link
Contributor Author

escapedcat commented Feb 20, 2024

Let me know if this is causing issues. Happy to adjust this.
Thanks for btcmap, really helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants