Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help links #131

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Add help links #131

merged 2 commits into from
Mar 15, 2024

Conversation

bubelov
Copy link
Collaborator

@bubelov bubelov commented Mar 13, 2024

Does this PR address a related issue?

A description of the changes proposed in the pull request

Screenshots

Additional context

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for btcmap ready!

Name Link
🔨 Latest commit 7ea6412
🔍 Latest deploy log https://app.netlify.com/sites/btcmap/deploys/65f3c5766d4b6c0007c46f03
😎 Deploy Preview https://deploy-preview-131--btcmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 44 (🔴 down 1 from production)
Accessibility: 84 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 100 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@secondl1ght secondl1ght self-requested a review March 13, 2024 15:53
@secondl1ght
Copy link
Member

I was thinking we could just turn the description ex. 'Outdated location' into a link that leads to the Wiki. What do you think? Is it better to have a dedicated column?

@bubelov
Copy link
Collaborator Author

bubelov commented Mar 14, 2024

I'm not sure if the description field is necessary since we have a type field. It would be stupid to send 100+ descriptions when we'll need to localize the app, and it's not good for sync and local storage

@bubelov
Copy link
Collaborator Author

bubelov commented Mar 14, 2024

So, the description column can be removed in the future, or it can be derived from the type field client-side. As for the link, I don't really care, but it's better if we put something actionable there as soon as possible

@secondl1ght
Copy link
Member

This is a good idea about deriving the descriptions from the types on the client-side. Just let me know when you want to deprecate that field in the backend and I will make the updates on the frontend.

@secondl1ght secondl1ght merged commit 33e1d6b into main Mar 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants