-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to @mitre/jsonix #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tragically, [Alexey (highsource) has passed away](highsource/jsonix#255) and his jsonix package is unlikely to receive any future updates. The [@mitre/jsonix fork](https://github.com/mitre/jsonix) appears to be a well-maintained and updated. We're going to switch to that.
Closed
Dependency ReviewThe following issues were found:
|
Both flagged dependencies have compatible licenses:
|
Note that Chai has become an ES module, so for the sake of simplicity, I have also made our tests
mike-marcacci
force-pushed
the
mitrej/jsonix
branch
from
October 3, 2024 22:32
6075f8c
to
53c0a4a
Compare
mike-marcacci
force-pushed
the
mitrej/jsonix
branch
from
October 3, 2024 22:47
b6c0f2e
to
4bebbc9
Compare
Quality Gate passedIssues Measures |
The differences in the mappings come down to explicit enum options now being defined. The seemingly large diffs are due to a difference in ordering of elements. |
nickcarenza
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tragically, Alexey (highsource) has passed away and his jsonix package is unlikely to receive any future updates.
The @mitre/jsonix fork appears to be a well-maintained and updated. We're going to switch to that.