Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @mitre/jsonix #5

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Switch to @mitre/jsonix #5

merged 9 commits into from
Oct 4, 2024

Conversation

mike-marcacci
Copy link
Member

Tragically, Alexey (highsource) has passed away and his jsonix package is unlikely to receive any future updates.

The @mitre/jsonix fork appears to be a well-maintained and updated. We're going to switch to that.

Tragically, [Alexey (highsource) has passed away](highsource/jsonix#255) and his jsonix package is unlikely to receive any future updates.

The [@mitre/jsonix fork](https://github.com/mitre/jsonix) appears to be a well-maintained and updated. We're going to switch to that.
@mike-marcacci mike-marcacci mentioned this pull request Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ❌ 1 package(s) with incompatible licenses
  • ❌ 1 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
  • ⚠️ 8 packages with OpenSSF Scorecard issues.

View full job summary

@mike-marcacci
Copy link
Member Author

Both flagged dependencies have compatible licenses:

  • amdefine is "NOASSERTION AND MIT" but not detected as MIT via automation
  • argparse is "Python-2.0" which is compatible with our standards for permissive licenses, and should be added to our allowlist

@mike-marcacci mike-marcacci marked this pull request as draft October 3, 2024 20:43
Note that Chai has become an ES module, so for the sake of simplicity, I have also made our tests
Copy link

sonarcloud bot commented Oct 3, 2024

@mike-marcacci mike-marcacci marked this pull request as ready for review October 3, 2024 23:01
@nickcarenza
Copy link
Contributor

The differences in the mappings come down to explicit enum options now being defined. The seemingly large diffs are due to a difference in ordering of elements.

@mike-marcacci mike-marcacci merged commit ff7011f into main Oct 4, 2024
4 of 5 checks passed
@mike-marcacci mike-marcacci deleted the mitrej/jsonix branch October 4, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants