Fix paths in npm build #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's good reason to keep npm etc. quarantined within Docker, but right now that workflow comes with a compile times around 100 seconds. Frontend developers need to make and test changes rapidly, and likely have these packages installed on their system already. This commit adds a `webpack.config.nodocker.js` file and `build-webpack.sh` to easily build with it. Compiling with `build-webpack.sh` takes around 3 seconds. A `package-lock.json` file is created by npm [for future developers](https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json#description) on any installs to manage dependencies, and I have no strong opinion on whether it should be removed from the GitHub repo. If developers have to install webpack and its plugins to run `build-webpack.sh`, a new `package-lock` will be created in their local `/src` folder. This commit also modifies several frontend files to accommodate the new webpack workflow, but this doesn't affect the `build-docker` workflow.
Also includes some general amendments to the README. Raymond E. Pasco's site is linked to in the contributor list, some installation instructions are clearer, and the README is lightly amended to reflect that @ashelkovnykov is no longer its sole author.
TypeScript's `tsc -w` command catches compile-time errors in your TypeScript files as soon as you save the file. This commit amends the "outDir" option for `tsconfig.json`, making a `tsc -w` compile more convenient by adding the created `tsc-watch` folder to `.gitignore`. This doesn't create a glob-ready build. As is, the `tsc -w` compile is only for catching errors in your `.ts` and `.tsx` files as soon as you make them, rather than waiting for a "real" compile attempt to finish.
Bug would kick subscribers before sending game results.
Release Candidate: 0.9.2
Release 0.9.4 for %413
Dump kelvin and update README
Fix `master` build issues
Dump kelvin (411)
bonbud-macryg
force-pushed
the
bm/fix-build
branch
from
26f0495
to
5d78e79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates paths in build script and Vite config for new
chess-uirepo.