Implement local source fetching #295
Conversation
Previously this resulted in a KeyError.
The build_srpm module handles this already so there's no need to duplicate it. It also moves the error handling to be local so it's easier to see where that would fail.
This adds the ability to fetch sources by using: (bundle exec) rake pkg:generate_source This is implemented in the Foreman repositories and makes it easier to run local scratch builds.
|
This initially feels like over reach to me. As in, something should have the ability to build or generate local source files but that should be a separate module or role that can then hand that off to the |
|
The thing I want to add too is to retrieve the commit and include that in the These instructions to build from a local directory (and for srpm) do not work anymore: https://github.com/theforeman/foreman-packaging/tree/rpm/develop#with-mock. |
|
I think you were on the right track with #178 as a dedicated module to handle building, that returns a path to the built source. That built source can then be fed into the This could even open the door for allowing a source_system that is github, source_location being the git repository, and source_ref that could handle building a PR. The build module you wrote could then fetch and build in a temporary directory and feed that to srpm module. |
This adds the ability to fetch sources by using:
(bundle exec) rake pkg:generate_source
This is implemented in the Foreman repositories and makes it easier to run local scratch builds.
It also fixes handling of remote sources and a TypeError.
The tests currently fail, but at least I've pushed my changes so I don't lose them.