-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New and improved version of the website #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sandra <sadindi03@gmail.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Signed-off-by: sandra <sadindi03@gmail.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Signed-off-by: sandra <sadindi03@gmail.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
chalin
added
enhancement
New feature or request
docsy
Docsy branch, and Docsy related items
labels
Oct 8, 2024
15 tasks
Looks nice. On
|
|
chalin
commented
Oct 12, 2024
Yes, this also looks great. I approve!
…On Sat, Oct 12, 2024 at 1:10 PM Patrice Chalin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In netlify.toml
<#105 (comment)>
:
>
[[headers]]
for = "/*"
[headers.values]
- Content-Security-Policy = "default-src 'self' code.jquery.com fonts.googleapis.com fonts.gstatic.com use.fontawesome.com app.netlify.com netlify-cdp-loader.netlify.app youtube.com; frame-src youtube.com www.youtube.com"
+ Content-Security-Policy = "default-src 'self' code.jquery.com fonts.googleapis.com fonts.gstatic.com cse.google.com www.google.com use.fontawesome.com app.netlify.com netlify-cdp-loader.netlify.app youtube.com; frame-src youtube.com www.youtube.com"
@JustinCappos <https://github.com/JustinCappos> et al.: I wanted to
highlight this addition to the CSP, i.e., two google.com sites, which I
added while experimenting with custom Google search for the website (#91
<#91>).
Please confirm that you are ok with this addition, otherwise I'll roll it
back.
—
Reply to this email directly, view it on GitHub
<#105 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGROD6QRJRUCDP4RMK4QFDZ3FJXFAVCNFSM6AAAAABPTHRYFSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRUGA2TGNBUGM>
.
You are receiving this because you were mentioned.Message ID:
<theupdateframework/theupdateframework.io/pull/105/review/2364053443@
github.com>
|
@jku - I created the following issue to track your comments: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-105--theupdateframework.netlify.app/