Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added union to DateTimeRange class #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added union to DateTimeRange class #34

wants to merge 1 commit into from

Conversation

atoaster
Copy link

Returns the timedelta of the total union of two DateTimeRange's

@thombashi thombashi self-requested a review December 13, 2020 05:40
thombashi
thombashi requested changes Dec 13, 2020
View reviewed changes
datetimerange/__init__.py
Returns the timedelta of the union of the input and current
DateTimeRange.

:param DateTimeRange x: List of DateTimeRanges.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x is not a List of DateTimeRange instances judging from what the method does.

@thombashi
Copy link
Owner

@atoaster
Thank you for your PR.

The method looks like useful for some use cases.
What concerns me is that the method name deviates from what the method does.
The method return value is not returning a union of DateTimeRange but timedelta.
I think that union_timedelta or something would be more suitable name for the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thombashi thombashi thombashi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atoaster @thombashi