Fix memory leak and potential props clash #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As discussed in person, there's a lot of overlap between
@threlte/test
and the vanilla @testing-library/svelte. As I was exploring integrating the two libraries more closely via a peer dependency relationship, a couple little issues got in my way that I figured I'd put a PR up forChange log
canvas
elements getting added to aSet
but never removedSet
componentProps
prop for the container