Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak and potential props clash #18

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

mcous
Copy link
Collaborator

@mcous mcous commented Jun 21, 2024

Overview

As discussed in person, there's a lot of overlap between @threlte/test and the vanilla @testing-library/svelte. As I was exploring integrating the two libraries more closely via a peer dependency relationship, a couple little issues got in my way that I figured I'd put a PR up for

Change log

  • Remove memory leak of canvas elements getting added to a Set but never removed
    • There didn't appear to be any actual cleanup needed, so I removed the Set
  • Ensure component props can't class with container props by creating an explicitly named componentProps prop for the container
    • This is easier to read in the code than it is to describe in a bullet point 🫠
  • Fix a bad validity check that would've allowed an array to masquerade as an object

@mcous mcous requested a review from michealparks June 21, 2024 14:29
Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 21bdb2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@threlte/test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@michealparks michealparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff as always, thank you!

@michealparks michealparks merged commit d3c23b8 into main Jun 21, 2024
2 checks passed
@michealparks michealparks deleted the stl-render-core-prep branch June 21, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants