Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove sidebar_class as undefined variable #148

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: remove sidebar_class as undefined variable #148

merged 1 commit into from
Nov 29, 2023

Conversation

Levdbas
Copy link
Member

@Levdbas Levdbas commented Nov 23, 2023

Removed unused variable from base.twig. It seems not to be defined anywhere.

@Levdbas Levdbas linked an issue Nov 23, 2023 that may be closed by this pull request
Question: What is sidebar_class? #137
Closed
@szepeviktor
Copy link
Contributor

Yes.
https://github.com/search?q=repo%3Atimber%2Fstarter-theme%20sidebar_class&type=code

@Levdbas Levdbas requested a review from gchtr November 23, 2023 09:36
@gchtr gchtr merged commit 3280b43 into 2.x Nov 29, 2023
9 checks passed
@gchtr gchtr deleted the 137-question-what-is-sidebar_class branch November 29, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchtr gchtr gchtr approved these changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: What is sidebar_class?
3 participants
@Levdbas @szepeviktor @gchtr