Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename static to assets. #157

Merged
merged 1 commit into from
May 14, 2024
Merged

feat: rename static to assets. #157

merged 1 commit into from
May 14, 2024

Conversation

Levdbas
Copy link
Member

@Levdbas Levdbas commented May 2, 2024

Related:

Issue

Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.

The static folder is not really the way to go anymore in modern WordPress theme development.

Solution

This particular PR focusses on renaming the static folder to assets, make a sub-structure with .gitkeep files and remove the no-timber.html file.

Impact

a better starting point to start your theme development workflow.

Usage Changes

No

Considerations

  • Not introducing all these folder?
  • re-introduce a way to inform people that they have not installed Timber? That was once were the no-timber.html file was for.
  • the style.css file is included in the head.html. I find myself using the enqueue functions to add compiled css/js files that way. Maybe we could one day in the future introduce a basic setup for this as well?

Testing

no

- Remove no-timber.html since it's no longer in use
- Introduce sub structure in the assets folder for modern development
- Update readme file to reflect these changes
@gchtr
Copy link
Member

gchtr commented May 14, 2024

  • the style.css file is included in the head.html. I find myself using the enqueue functions to add compiled css/js files that way. Maybe we could one day in the future introduce a basic setup for this as well?

Let’s stick to wp_enqueue_style(). We don’t have to invent our own way to do it.

@Levdbas Levdbas merged commit 0129442 into 2.x May 14, 2024
4 of 9 checks passed
@Levdbas Levdbas deleted the feat-static-to-assets branch May 14, 2024 07:34
@Levdbas Levdbas mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants