Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2480: Port to 6 Docs - Update svelte-quick-start.adoc to use Vite v5 #3389

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

FarzadHayat
Copy link
Contributor

@FarzadHayat FarzadHayat commented Jul 10, 2024

Ticket: DOC-2480

Site: Svelte Cloud
Site: Svelte Package Manager
Site: Svelte Zip

Changes:

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.
  • [-] modules/ROOT/nav.adoc has been updated (if applicable).
  • [-] Included a release note entry for any New product features.
  • [-] If this is a minor release, updated productminorversion in antora.yml and added new supported versions entry in modules/ROOT/partials/misc/supported-versions.adoc.

Review:

  • Documentation Team Lead has reviewed

@FarzadHayat FarzadHayat requested review from kemister85, danoaky-tiny and a team July 10, 2024 02:07
@FarzadHayat FarzadHayat self-assigned this Jul 10, 2024
@FarzadHayat FarzadHayat requested review from Afraithe, MitchC1999, ltrouton and tiny-ben-tran and removed request for a team July 10, 2024 02:07
@FarzadHayat FarzadHayat changed the title DOC-2480: Port to 6 Docs - Update svelte-quick-start.adoc to use Vite v5 DOC-2480: Port to 6 Docs - Update svelte-quick-start.adoc to use Vite v5 Jul 10, 2024
@FarzadHayat FarzadHayat marked this pull request as draft July 10, 2024 05:24
@FarzadHayat FarzadHayat marked this pull request as ready for review July 11, 2024 00:07
@FarzadHayat FarzadHayat requested a review from a team as a code owner July 11, 2024 00:07
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@FarzadHayat FarzadHayat merged commit 07a2caf into tinymce/6 Jul 17, 2024
5 checks passed
@FarzadHayat FarzadHayat deleted the hotfix/6/DOC-2480 branch July 17, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants