Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backup share to factor key #44

Merged
merged 13 commits into from
Aug 17, 2023
Merged

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Aug 15, 2023

No description provided.

Copy link
Collaborator

@metalurgical metalurgical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes are needed, otherwise nicely done.

Sources/ThresholdKey/Modules/TssModule.swift Outdated Show resolved Hide resolved
Sources/ThresholdKey/Modules/TssModule.swift Outdated Show resolved Hide resolved
Sources/ThresholdKey/Modules/TssModule.swift Show resolved Hide resolved
Sources/ThresholdKey/Modules/TssModule.swift Show resolved Hide resolved
Sources/ThresholdKey/ThresholdKey.swift Outdated Show resolved Hide resolved
Sources/ThresholdKey/ThresholdKey.swift Outdated Show resolved Hide resolved
Sources/ThresholdKey/ThresholdKey.swift Outdated Show resolved Hide resolved
Tests/tkeypkgTests/IntegrationTests.swift Outdated Show resolved Hide resolved
Copy link
Collaborator

@metalurgical metalurgical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when tests pass

@metalurgical metalurgical merged commit 6bc12aa into v2 Aug 17, 2023
1 check passed
@metalurgical metalurgical deleted the feat/backup-share-to-factor-key branch August 21, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants