-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): improve accessibility with targeted :focus-visible
focus styles for non-pointer devices
#796
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
:focus-visible
focus styles for non-pointer devices:focus-visible
focus styles for non-pointing devices
:focus-visible
focus styles for non-pointing devices:focus-visible
focus styles for non-pointer devices
:focus-visible
focus styles for non-pointer devices:focus-visible
focus styles for non-pointer devices
Tonic UI Demo
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #796 +/- ##
==========================================
- Coverage 71.76% 71.35% -0.41%
==========================================
Files 374 374
Lines 6243 6256 +13
==========================================
- Hits 4480 4464 -16
- Misses 1763 1792 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
36d624f
to
5d5380f
Compare
ca80209
to
cb4240e
Compare
d35e456
to
0793561
Compare
a951561
to
27e18a7
Compare
… focus style for non-pointer devices
… focus style for non-pointer devices
…ed focus style for non-pointer devices
…eted focus style for non-pointer devices
…d focus style for non-pointer devices
… focus style for non-pointer devices
…pseudo-style rendering
…geted focus style for non-pointer devices
…ed focus style for non-pointer devices
…nuitemradio`, `treeitem`, `gridcell`, `row`, `rowheader`, and `columnheader`
…rgeted focus style for non-pointer devices
Enhance accessibility with selective
:focus-visible
focus styles for non-pointer devices:packages/react
Button
ButtonGroup
ModalCloseButton
DrawerCloseButton
ToastCloseButton
AlertCloseButton
TagCloseButton
Checkbox
Radio
Switch
Menu
Pagination
Tabs
Tree
packages/react-docs
Side navigation menu
Action buttons of the example code
Reference
https://hidde.blog/focus-visible-more-than-keyboard/
:focus-visible
should apply to interactions via keyboard or some other non-pointing device.