Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): enhance controlled behavior of SearchInput using selectionStart and selectionEnd for cursor position preservation #800

Merged
merged 2 commits into from
Sep 3, 2023
Merged

feat(react): enhance controlled behavior of SearchInput using selectionStart and selectionEnd for cursor position preservation #800

merged 2 commits into from
Sep 3, 2023

Conversation

cheton
Copy link
Member

@cheton cheton commented Aug 31, 2023 •
edited
Loading

@codesandbox
Copy link

codesandbox bot commented Aug 31, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@cheton cheton linked an issue Aug 31, 2023 that may be closed by this pull request
Input cursor position changes to end in SearchInput when controlled usage #797
Closed
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@trendmicro-frontend-bot
Copy link
Contributor

Tonic UI Demo

@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (a80d4cc) 71.66% compared to head (977b96e) 71.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   71.66%   71.72%   +0.06%     
==========================================
  Files         373      374       +1     
  Lines        6221     6236      +15     
==========================================
+ Hits         4458     4473      +15     
  Misses       1763     1763
Flag Coverage Δ
react 73.50% <100.00%> (+0.07%) ⬆️
react-hooks 87.58% <ø> (ø)
react-lab 14.04% <ø> (ø)
styled-system 91.73% <ø> (ø)
theme 100.00% <ø> (ø)
utils 70.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/react/src/search-input/SearchInput.js 73.07% <100.00%> (+4.18%) ⬆️
packages/react/src/utils/useRunAfterUpdate.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

light049
light049 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@light049 light049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cheton cheton merged commit 1e394cb into master Sep 3, 2023
4 checks passed
@cheton cheton deleted the tonic-ui-797 branch September 3, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@light049 light049 light049 approved these changes

@tinaClin tinaClin Awaiting requested review from tinaClin

Assignees

@cheton cheton

@light049 light049

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input cursor position changes to end in SearchInput when controlled usage
3 participants
@cheton @trendmicro-frontend-bot @light049