Fix issue with detection whether to use ipv6 or ipv4 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the changes in my setup with the workaround removed successfully. Got confused by the log message while running in a locally built docker: inadyn-1 | inadyn[1]: Updating IPv6 cache for ipv4@ipv64.net which I fixed with 4ea7896 |
The issue was occurring while checking whether the provider name contained "ipv6" as an indication for whether to use IPv4 or IPv4. The check confused a definition like "ipv4@ipv64.net" to use IPv6 due to having "ipv6" in the name. To address the issue we changed the check to whether the prefix of the provider name is "ipv6". While doing so, we factored out this check into a own function taking a ddns_info_* struct as an argument.
hrzlgnm
force-pushed
the
497-fix-issues-with-checking-whether-to-use-ivp6
branch
from
773c795
to
28d875c
Compare
The original check, checked whether the alias name contained the substring "v6". This lead to confusing logging messages for providers having "v6" in their name. For example in definitions like "ipv4@ipv64.net" or "ipv4@dynv6.com".
hrzlgnm
force-pushed
the
497-fix-issues-with-checking-whether-to-use-ivp6
branch
from
28d875c
to
4ea7896
Compare
|
@troglobit, if you want the second commit in a separate issue with a separate PR let me know. Both topics were related, so I thought it made sense to squash those issues with one PR. |
|
I'm currently using this branch to build a docker image which i then use in a docker-compose setup, and i can use ipv64.net and the dynv6.com providers without issues so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was occurring while checking whether the provider name contained
"ipv6" as an indication for whether to use IPv4 or IPv4. The check
confused a definition like "ipv4@ipv64.net" to use IPv6 due to having
"ipv6" in the name.
To address the issue we changed the check to whether the prefix of
the provider name is "ipv6".
While doing so, we factored out this check into a own function taking
a ddns_info_t * struct as an argument.