5.0: Update django.contrib.contenttypes.prefetch
#2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaeHyuckSa
changed the title
django.contrib.contenttypes.prefetch
sobolevn
reviewed
May 3, 2024
| from django.db.models.query import QuerySet | ||
|
|
||
| class GenericPrefetch(Prefetch): | ||
| def __init__(self, lookup: str, querysets: list[QuerySet] | None = ..., to_attr: str | None = ...) -> None: ... |
There was a problem hiding this comment.
Please, see django/django#18125
There was a problem hiding this comment.
@sobolevn I've read the corresponding PR. It's a shame that if I had thought about it a little more, I would have found a bug. Still, thank you for letting me know the good opportunity :) I'm learning again today. If Django PR merges, I'll fix the code and apply it.
|
I have confirmed that the code has been applied! I will fix it and commit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Update stubs for
django.contrib.contenttypes.prefetchfor Django 5.0.django.contrib.contenttypes.prefetchdjango.contrib.contenttypes.prefetch.GenericPrefetchwas addedRelated issues
Refs
Upstream PR