5.0: Update django.contrib.messages.test
#2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
May 5, 2024
sobolevn
approved these changes
May 6, 2024
There was a problem hiding this comment.
You can transform BaseStorage into list. See https://github.com/django/django/blob/34a503162fe222033a1cd3249bccad014fcd1d20/django/contrib/messages/storage/base.py#L64-L72
And it will work with https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertCountEqual
So, I would prefer to keep it here 👍
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Update stubs for
django.contrib.messages.testfor Django 5.0.django.contrib.messages.testwas addedRelated issues
Refs
Upstream PR