Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chgres_cube: Implement WMO grib2 template 1 (rotated lat-lon) read capability #902

Conversation

LarissaReames-NOAA
Copy link
Collaborator

@LarissaReames-NOAA LarissaReames-NOAA commented Feb 23, 2024

DESCRIPTION OF CHANGES:

RRFS Fire needs to be able to initialize from the rotated lat-lon grib2 RRFS files which are on the WMO grib2 template 1. This implements the capacity to read data on that template. Also added 'RRFS' as a supported external_model namelist input. though it's not required to support this grid template. Full versions of those RRFS file, however, are still not supported as they are too large (>2GB). That will be addressed when #850 is fixed.

TESTS CONDUCTED:

Intel builds on Jet and Hera. Gnu builds on Hera. Unit tests pass on Hera. Consistency tests pass on Hera. Need support for: Orion, Hercules, WCOSS2 intel builds. Debug build on WCOSS2.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2). Done using 804ea27.
  • Compile branch on Hera using GNU. Done using 804ea27.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Dogwood using 804ea27.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using 804ea27.
  • Run relevant consistency tests locally on all Tier 1 machine. Done using 804ea27. All tests failed on Jet. However, the baseline was created on xjet. Those nodes have been migrated to a new operating system, on which UFS_UTILS has not been tested. Running on vjet nodes resulted in floating point differences.

DEPENDENCIES:

N/A

DOCUMENTATION:

Updated documentation to note that 'RRFS' is now a supported external_model option.

ISSUE:

Resolves #901

CONTRIBUTORS (optional):

@GeorgeGayno-NOAA contributed the grib1 grid definition information

@GeorgeGayno-NOAA
Copy link
Collaborator

Should we add a new consistency test? This test uses the local NCEP template for rotated latl/on:

The new test could be the same except for the input data (which would use the WMO template).

@LarissaReames-NOAA
Copy link
Collaborator Author

LarissaReames-NOAA commented Feb 23, 2024

Should we add a new consistency test? This test uses the local NCEP template for rotated latl/on:

The new test could be the same except for the input data (which would use the WMO template).

I'd thought about that, but thought maybe we'd wait until we can support the full RRFS grib2 files with the new g2 library. I was only able to confirm that the current updates worked with a sub-CONUS file from Ben interpolated to an even smaller sub-CONUS output grid.

@GeorgeGayno-NOAA
Copy link
Collaborator

Should we add a new consistency test? This test uses the local NCEP template for rotated latl/on:

The new test could be the same except for the input data (which would use the WMO template).

I'd thought about that, but thought maybe we'd wait until we can support the full RRFS grib2 files with the new g2 library. I was only able to confirm that the current updates worked with a sub-CONUS file from Ben interpolated to an even smaller sub-CONUS output grid.

Did you test the coldstart files in the model?

I will help with testing on the machines you don't have access to.

@GeorgeGayno-NOAA
Copy link
Collaborator

@LarissaReames-NOAA Can I merge this?

@LarissaReames-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA sounds good to me!

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 1dac855 into ufs-community:develop Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add chgres_cube capability to read data on WMO rotated lat-lon grid (template 1)
3 participants