-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving intellisense by fixing XML warnings #14663
Conversation
Hi there @nikcio, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
This reverts commit 8ea61c5.
Hi @nikcio , Thanks a lot for this pull request! So many files 🫣, but lots of good fixes! I ended up reverting your commit Thanks again for the great work! 🙌 |
Prerequisites
Description
This fixes many of the XML warnings that are in the project. Many of the warnings broke the comment so it wasn't displayed anywhere. It was mostly legacy documentation that wasn't updated correctly and
&
that wasn't escaped correctly.Note I added some white space to:
src/Umbraco.Infrastructure/WebAssets/ServerVariables.js
because placing the//
right up against the generated XML comment in the designer file breaks the XML comment.This shouldn't affect any of the actual code only the XML comments.