TemplateService should return all templates from GetAllAsync if no keys are passed #16254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This is the
TemplateService
equivalent of #16230To align functionality of our services,
GetAllAsync(params Guid[] keys)
must return all templates if no keys have been passed to the method.This is functionally breaking, but "only" towards the new V14 service methods.
I have verified that all consumers of this method are guarded by an explicit check for zero results, thus ensuring we don't accidentally return all templates when we're in fact wanting to return none.
Testing this PR
GetAllAsync(params Guid[] keys)
is only used by the template "item" and "search" endpoints. Both should still work 😄