Distinguish between default zero and intentional zero sort order for new documents #17517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17273
Description
The current
PersistNewItem
logic inDocumentRepository
checks whether the sort order already exits in the database and changes the sortOrder if so, else persists the sortorder on the entity. This was added in #13644 specifically for documents to support maintaining the sortorder oncopy with descendants
which is an action that is only supported for documents.Since the default value of an int is 0 and the lowest sortOrder we support is 0, we can not tell the difference between
This PR proposes to
TreeEntityBase
class to -1Considerations
TreeEntityBase
implicetly update the sortOrder value, so a -1 will not be persistedTesting
TreeEntityBase
derived classes exist.