Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: c4gh deploy #271

Merged
merged 7 commits into from
Oct 16, 2024
Merged

fix: c4gh deploy #271

merged 7 commits into from
Oct 16, 2024

Conversation

mmalenic
Copy link
Member

Features

  • Add component which fetches secrets from AWS Secrets Manager.
    • Currently this can fetch private/public C4GH keys, and is used by the CDK deployment code to enable C4GH.

Fixes

  • Allow passing additional compiler flags to CDK code.
  • Fix an issue with C4GHStorage which failed to read the correct amount data from the underlying stream.
    • The fix involves first determining the size of the C4GH header, and then sending another request to read the rest of the data.
    • This has to be done in two steps because it is not possible to know the amount of data that needs to be fetched without first knowing the size of the C4GH header.
  • Fixed a failing test due to reused ports.

Misc

@mmalenic mmalenic self-assigned this Oct 16, 2024
@mmalenic mmalenic added the fix fix a bug label Oct 16, 2024
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos! 🚀

htsget-search/src/bam_search.rs Outdated Show resolved Hide resolved
htsget-storage/src/s3.rs Show resolved Hide resolved
deploy/config/example_deploy.toml Show resolved Hide resolved
@mmalenic mmalenic added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit d6ec3b8 Oct 16, 2024
5 checks passed
@brainstorm brainstorm deleted the fix/experimental-deploy branch October 20, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants