fix: nprogress always pending in custom react pages #1793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是?/ What is the nature of this change?
🔗 相关 Issue / Related Issue
Close #1750
💡 需求背景和解决方案 / Background or solution
修复启用 nprogress 时,打开自定义 React 页面进度条不会完成的 bug,原因是之前仅对 Markdown 异步路由的加载状态做了捕获
新的解决方案是借助 Suspense 的 fallback 组件(也就是 Umi 的 loading 组件)来设置加载状态,dumi 总是会内置一个空白 loading 来处理加载逻辑,如果用户有配置 loading 时,dumi 的内置 loading 则会包在用户的外面,不影响原有功能
这个方案相比原方案的好处是:
📝 更新日志 / Changelog