Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add istio example (#29) #32

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

marcelloale
Copy link
Contributor

Description

Add Istio example access log filtering using CEL

Linked Issues

#29

@matheusfm
Copy link
Contributor

matheusfm commented Oct 10, 2023

Hi @marcelloale
Thank you for this PR! I appreciate your contribution.

Could you please include the other fields in the input data of the example?

I see that you've included only response.code and xds.cluster_name, but there are several other fields documented here.

Please run also make update-data

@matheusfm
Copy link
Contributor

Hi, @marcelloale

Here are some examples of Istio/Envoy attributes for CEL: https://gist.github.com/matheusfm/31e96d49159937266e5bb88d69fddb91

This gist contains three YAML-formatted examples, where client-passthrough-http.yml seems to be related to the CEL expression you are adding, as xds.cluster_name is PassthroughCluster.

Could you please consider using this example as input data?

PS: A big thank you to @howardjohn for their help with these examples.

@marcelloale
Copy link
Contributor Author

Hi, @marcelloale

Here are some examples of Istio/Envoy attributes for CEL: https://gist.github.com/matheusfm/31e96d49159937266e5bb88d69fddb91

This gist contains three YAML-formatted examples, where client-passthrough-http.yml seems to be related to the CEL expression you are adding, as xds.cluster_name is PassthroughCluster.

Could you please consider using this example as input data?

PS: A big thank you to @howardjohn for their help with these examples.

Hi @matheusfm ,

I've been occupied over the past week, but I intend to make the necessary adjustments as soon as possible this weekend.

I want to thank @matheusfm and @howardjohn for the examples.

@marcelloale
Copy link
Contributor Author

Hi @matheusfm, I've added the new input data, but I removed some 'null' fields to reduce the size of the example. If necessary, I can commit the original example without any alterations.

@matheusfm
Copy link
Contributor

Thank you @marcelloale for the collaboration!

Could you resolve git conflicts please? Then we can merge these changes.

@marcelloale
Copy link
Contributor Author

@matheusfm done

@matheusfm matheusfm merged commit 393ad23 into undistro:main Nov 1, 2023
3 checks passed
@matheusfm
Copy link
Contributor

Thank you very much @marcelloale for your contribution and collaboration. We really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants