Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom metrics istio example #40

Merged
merged 1 commit into from
Nov 1, 2023
Merged

feat: add custom metrics istio example #40

merged 1 commit into from
Nov 1, 2023

Conversation

matheusfm
Copy link
Contributor

Description

Add custom metrics istio example

How has this been tested?

  • make serve
  • Run Custom Metrics example

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the enhancement New feature or request label Nov 1, 2023
@matheusfm matheusfm self-assigned this Nov 1, 2023
lucasjct
lucasjct approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matheusfm matheusfm merged commit a015ab6 into main Nov 1, 2023
5 checks passed
@matheusfm matheusfm deleted the feat/istio-custom-metrics-example branch November 1, 2023 14:16
@howardjohn howardjohn mentioned this pull request Nov 3, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasjct lucasjct lucasjct approved these changes

@joaovictor3g joaovictor3g Awaiting requested review from joaovictor3g

Assignees

@matheusfm matheusfm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusfm @lucasjct