Fix #586: require newer excon, use valid parameter keys interface

upserve · Jul 8, 2024 · 0f6be13 · 0f6be13
1 parent 6f7b7cd
commit 0f6be13
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/docker-api.gemspec b/docker-api.gemspec
@@ -10,7 +10,7 @@ Gem::Specification.new do |gem|
   gem.files         = `git ls-files lib README.md LICENSE`.split($\)
   gem.name          = 'docker-api'
   gem.version       = Docker::VERSION
-  gem.add_dependency 'excon', '>= 0.47.0'
+  gem.add_dependency 'excon', '>= 0.64.0'
   gem.add_dependency 'multi_json'
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec', '~> 3.0'

diff --git a/lib/excon/middlewares/hijack.rb b/lib/excon/middlewares/hijack.rb
@@ -1,11 +1,13 @@
 module Excon
-  VALID_REQUEST_KEYS << :hijack_block
-
   module Middleware
     # Hijack is an Excon middleware which parses response headers and then
     # yields the underlying TCP socket for raw TCP communication (used to
     # attach to STDIN of containers).
     class Hijack < Base
+      def self.valid_parameter_keys
+        [:hijack_block].freeze
+      end
+
       def build_response(status, socket)
         response = {
           :body          => '',