Ensure that docker-api works with frozen strings #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. One question, but otherwise I'd be happy to merge. |
Rakefile
Outdated
| require 'bundler/setup' | ||
|
|
||
| ENV['PATH'] = "/opt/docker/:#{ENV['PATH']}" if ENV['CI'] == 'true' | ||
|
|
||
| require 'docker' | ||
| require 'rspec/core/rake_task' | ||
| require 'cane/rake_task' | ||
|
|
||
|
|
||
| desc 'Run the full test suite from scratch' | ||
| task :default => [:unpack, :rspec, :quality] |
There was a problem hiding this comment.
Ah, can we also remove the quality from this array?
There was a problem hiding this comment.
Ah yes, of course. Sorry I missed that.
I also now noticed a mention of rake quality in the Readme; that has been removed as well.
It doesn't work with Ruby 3.1+, and in 2018 its maintainer wrote that users should consider switching to RuboCop.
bquorning
force-pushed
the
frozen-strings
branch
from
11947a5
to
f03cdb5
Compare
|
Seems like the |
I think after Ruby 3.4 is released[^1], more people will start expecting libraries to be functional with eg the `--enable-frozen-string-literal` option enabled. This commit adds the `frozen_string_literal` header to all files and fixes failing tests. [^1]:ruby/ruby@12be40a
bquorning
force-pushed
the
frozen-strings
branch
from
f03cdb5
to
c416cfd
Compare
|
Fixed and pushed. |
|
Released as v2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think after Ruby 3.4 is released1, more people will start expecting libraries to be functional with e.g. the
--enable-frozen-string-literaloption enabled.This PR adds the
frozen_string_literalheader to all files and fixes failing tests.This PR also configures CI to run tests with Ruby versions 3.0 up to 3.3. This in turn means that the
canegem had to be removed. It was last updated 6 years ago, and that last change was telling people to start using RuboCop instead (however, I feel such a change is out of scope for this PR).Footnotes
https://github.com/ruby/ruby/commit/12be40ae6be78ac41e8e3f3c313cc6f63e7fa6c4 ↩