-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1929 update markdown link #1929
1929 update markdown link #1929
Conversation
1188c69
to
0654071
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for taking care of this.
@Arminta-Jenkins-NIST, I can tell the xmllint.net failure is an ephemeral one in this failed build, but as a learning experience, can you go to the failed build and click re-run job to test that? This transient error has happened with this domain in the past. If it does not go green this time, I will merge anyway (it happens every few months), but you corrected what you need. I will just note it in the checklist. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If you hadn't done it yet, Arminta, you can disregard. An updated link checker pass this evening confirms there is some issue with the GH infrastructure and xmllint.net and the linux.die.net manual page mirror sites too (ironically enough): #1926 (comment). I will merge this now to stop some of the issues and open a new issue to suppress checks for those domains tomorrow if it keeps happening. |
Committer Notes
Updates links in the
src/specifications/profile-resolution/readme.md
. Closes #1926.All Submissions:
Do all automated CI/CD checks pass?(Will follow up see Scheduled Check of Markdown Documents Found Bad Hyperlinks #1926 (comment) for unrelated issue but still from link checking.)By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.