Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLSC-20] Implement Skeleton Email Service #6

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

Mayank808
Copy link
Collaborator

Notion ticket link

Setup Basic Email System

Implementation description

Setup a quick skeleton for email service with interfaces and classes defined. Will be implementing actual functionality in next pr. Created a test endpoint to ensure that implementation of skeleton classes is done properly just need to add actual logic.

Steps to test

  1. Can run backend properly
  2. Hit the new test email API. Can check fast API docs for params/requirements

What should reviewers focus on?

  • Interface definitions other functionalities that we may ned

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

backend/app/routes/email.py Outdated Show resolved Hide resolved
backend/app/routes/email.py Show resolved Hide resolved
backend/app/server.py Outdated Show resolved Hide resolved
backend/app/services/email/email_service_provider.py Outdated Show resolved Hide resolved
backend/app/services/email/email_service.py Show resolved Hide resolved
backend/app/services/email/email_service.py Show resolved Hide resolved
backend/app/services/email/email_service.py Outdated Show resolved Hide resolved
backend/app/services/email/email_service_provider.py Outdated Show resolved Hide resolved
backend/app/routes/email.py Outdated Show resolved Hide resolved
backend/app/services/interfaces/email_service_provider.py Outdated Show resolved Hide resolved
@Mayank808 Mayank808 changed the base branch from main to firebase-auth-branch November 3, 2024 21:57
@Mayank808 Mayank808 changed the base branch from firebase-auth-branch to main November 3, 2024 21:57
@Mayank808 Mayank808 force-pushed the mayank/LLSC-20-email-service-skeleton branch from a219fe2 to e82edf4 Compare November 3, 2024 22:01
Copy link
Collaborator

@mslwang mslwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Given that the ticket includes using an email provider, we can either split this PR into a separate ticket or have the email provider implementation under the same ticket.

@mslwang mslwang changed the title Implement Skeleton Email Service [LLSC-20] Implement Skeleton Email Service Nov 8, 2024
Copy link
Collaborator

@EdmondLi1 EdmondLi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mayank808 Mayank808 merged commit 37e30a4 into main Nov 10, 2024
1 check passed
@Mayank808 Mayank808 deleted the mayank/LLSC-20-email-service-skeleton branch November 10, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants