Done Week 4 #67
Open
Done Week 4 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzioLi01
reviewed
Aug 29, 2024
| public int MathScore { get; set; } | ||
| public int EnglishScore { get; set; } | ||
| public int ProgrammingScore { get; set; } | ||
| public int TotalScore => MathScore + EnglishScore + ProgrammingScore; //add all scores |
There was a problem hiding this comment.
Generally we add a comment above the target code, and need a space between // and string.
DevPaulLiu
reviewed
Sep 24, 2024
| { | ||
| var students = new List<Student>(); //declare student list | ||
|
|
||
| using (var StudentData = new StreamReader("Student.csv")) //read csv file |
There was a problem hiding this comment.
It's better to create different files for different classes, and define separate functions, then call these function from main.
|
Alright, will refine my code and repush the updated one. Thank you for the comments and suggestions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.