-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(githooks): add pre-commit scripts for adorno #34
Conversation
@@ -0,0 +1,21 @@ | |||
#!/bin/bash | |||
|
|||
foundryup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I want tihs hook to automatically update the tooling on my machine.
@gravityblast wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the same @0x-r4bbit . I don't really like precommits forced in the repo.
I prefer them to be forced on CI but optional in local
Can we do it ran just once a day? Or in some other action. Somehow we need this because our CI always have latest foundry and updates happen frequently, more than once a day |
I think we need to make a decision here:
I guess I prefer option 1. Wdyt @3esmit @gravityblast ? |
If we can't reach consensus here we can also just go with option 2) which means leaving things as is. So by adding this here, it's not gonna be automatically executed on our machines. Hooks have to live in I'm fine either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve this now...
@3esmit You need to sign your commits, then this can be merged. |
Done. |
Awesome! |
Description
I always have this problem on forgetting to send lint to the PR, than the CI will run and fail, and I will have to do --force commits.
This would automate the process by automatically running commands we have to use before commiting.
This githook can be enabled by adding a file on .git/hooks folder calling these scripts.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno
?pnpm verify
?