More fixes #302
Merged
More fixes #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Nov 18, 2024
mbaldessari
commented
- Fix whitespaces
- Fix checking out of staging-approval branch
- Try and fix the PR pipeline
- Talk to the model server on the hub for now
We do a couple of things here: - if STARTINGBRANCH is set we create a local branch from this STARTINGBRANCH, we call it BRANCH and make sure the upstream is set to origin/BRANCH. This way we are sure we always use a local branch called BRANCH and ignore if an upstream already had BRANCH named like that. - We force push this BRANCH when we push back to gitea Co-Authored-By: Akos Eros <aeros@redhat.com>
Here we switch to using the proper curl command to create a PR in gitea by default instead of github. Likely we'd need some changes here if also need to support github for this process. Co-Authored-By: Akos Eros <aeros@redhat.com>
This is an initial pass at making a stock deployment to just work. Basically we tell the messaging component on a factory (which represents a production workload) to talk to the inference server in the manuela-tst-all namespace on the hub. This change will need more in-depth discussion in the future and we need to clear up the exact workflow. We could decide to spin up an inference server in the factory as well and have it load a model from the hub's S3, but it might get a bit too onerous for a demo setup like this one. So for the time being, let's use this approach to at least get the line dashboard working on the factory, out of the box. Co-Authored-By: Akos Eros <aeros@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.