Skip to content

Commit

Permalink
Stop using eslint as it is completely broken: config is utterly messe…
Browse files Browse the repository at this point in the history
…d up and stupid, checkout the tseslint config, that just does not make any sense (wtf do they need to call everything flat now), also config through package.json has been removed, this stupidest soft can't freaking ignore the files that are in .gitignore (how is it hard to understand, so many software have now sane and logical defaults, but this one just do everything wrong, so byebye) and adding paths in ignore does not work
  • Loading branch information
vemonet committed Oct 15, 2024
1 parent aeac245 commit 4c30b57
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,12 @@ jobs:
- name: Install frontend dependencies
run: npm ci

- name: Lint check
if: matrix.platform == 'ubuntu-latest'
run: npm run lint
# Removed because eslint is ridiculously broken.
# How hard is it to understand it should not lint freaking files that are in .gitignore?
# That's a whole new level of incompetence.
# - name: Lint check
# if: matrix.platform == 'ubuntu-latest'
# run: npm run lint

- name: Build with tauri to test
if: github.ref != 'refs/heads/release'
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ release:
fmt:
cd src-tauri && cargo fmt
npm run fmt
npm run lint

desktop-local:
cp "src-tauri/target/release/bundle/appimage/emoji-mart_*_amd64.AppImage" "~/.local/bin/EmojiMart.AppImage"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"upgrade": "npx npm-check-updates -u && npm install",
"test": "vitest",
"lint": "eslint . --ignore-path .gitignore",
"lint": "eslint .",
"fmt": "prettier \"**/*.{svelte,ts,tsx,js,cjs,yml,md,html,css}\" --ignore-path .gitignore --write",
"internationalize": "node resources/internationalize.js"
},
Expand Down
2 changes: 1 addition & 1 deletion resources/internationalize.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { readFileSync, readdirSync, writeFileSync } from 'fs'

const emojiVersion = process.argv[2] || "15";
const emojiVersion = process.argv[2] || '15'

console.log(`🚀 Generating translations for emojis version ${emojiVersion}`)

Expand Down
1 change: 0 additions & 1 deletion src-tauri/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ pub fn run() {
.expect("[EmojiMart] Error while running tauri application");
}


// fn show_window(app: &AppHandle) {
// let windows = app.webview_windows();
// windows
Expand Down
2 changes: 1 addition & 1 deletion src/routes/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
// Load the emoji data from this repo, precompiled for different languages
try {
i18n = (await import(`@emoji-mart/data/i18n/${lang}.json`)).default;
i18n = (await import(`@emoji-mart/data/i18n/${lang}.json`)).default
data = (await import(`../data/${lang}.json`)).default
} catch (err) {
console.error(`Language ${lang} not supported, loading default`)
Expand Down

0 comments on commit 4c30b57

Please sign in to comment.