Add new embed parameters for start_time, end_time, chapter_id, and watch_full_video #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
=======================================
Coverage 72.00% 72.00%
=======================================
Files 7 7
Lines 575 575
=======================================
Hits 414 414
Misses 161 161 ☔ View full report in Codecov by Sentry. |
jdreetz
changed the title
christriants
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for several new embed options:
start_time: what time (in seconds) to start video playback at.end_time: what time (in seconds) playback should end. Enables "Segmented Playback" mode, where the UI is updated to present the video as if it's duration is that of the selected time range. Note: ifstart_timeis not set, it defaults to0when end_time is set.watch_full_video: when "Segmented Playback" is enabled, this setting controls visibility of the "Watch Full Video" Button. This button is enabled by default when Segmented Playback is enabled.chapter_id: what chapter (by id) to start video playback at.