Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: buildless ecosystem ci #18525

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

Aslemammad
Copy link
Contributor

By using the --commit option in vite-ecosystem-ci, we can leverage the already built versions of vite in pkg.pr.new!

Here, after sending the ecosystem comment, we'll check if there's an already built version, if not, we'll try triggering a build. The 🚀 reaction is a sign that the build is happening and we should wait until it's done.

After that, the normal process continues.

@Aslemammad
Copy link
Contributor Author

/ecosystem-ci run

Copy link

pkg-pr-new bot commented Nov 1, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/vitejs/vite@18525

commit: c97f0eb

@Aslemammad
Copy link
Contributor Author

Aslemammad commented Nov 5, 2024 via email

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 5406307: Open

suite result latest scheduled
astro failure failure
histoire failure failure
redwoodjs failure failure
remix failure failure
sveltekit failure failure
unocss failure failure
vike failure failure
vite-environment-examples failure success
vite-plugin-react success failure
vite-plugin-svelte success failure
vite-plugin-vue failure failure
vitest failure failure

analogjs, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, vite-plugin-pwa, vite-plugin-react-swc, vite-setup-catalogue, vitepress, vuepress

.github/workflows/ecosystem-ci-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/ecosystem-ci-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/ecosystem-ci-trigger.yml Show resolved Hide resolved
.github/workflows/ecosystem-ci-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/ecosystem-ci-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/ecosystem-ci-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/ecosystem-ci-trigger.yml Outdated Show resolved Hide resolved
Aslemammad and others added 7 commits November 6, 2024 09:23
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
sapphi-red previously approved these changes Nov 6, 2024
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants