Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SonarAnalyzer.CSharp from 8.25.0.33663 to 9.7.0.75501 in /singletonclient #2542

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Aug 7, 2023

Bumps SonarAnalyzer.CSharp from 8.25.0.33663 to 9.7.0.75501.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

9.7

This release focused on improving the precision of existing rules. We fixed a lot of False Positives, False Negatives, and bugs in Code Fixes.

We also reduced our memory footprint by reducing allocations in the hot path. Thank you @​sharwell, for reporting this in #7439 and #7440.

Special thanks to our contributor @​nalka0 for the correction of our rule documentation in #7587

Improvements

  • 7462 - [C#] Fix S1125: Codefix should set correct condition priority by adding parentheses.
  • 2618 - [C#] Fix S1125: Faulty code fix on C# pattern matching in conditional operator
  • 7213 - [C#] Improve S109 message

False Positive

  • 7633 - [C#] Fix S4023 FP: Interfaces that provide type parameters from base interface
  • 7629 - [C#] Fix S1186 FP: Empty method comes from interface
  • 7508 - [C#, VB.NET] Fix S6605 FP: Should not fire in expressions
  • 7324 - [C#] Fix S3063 FP: StringBuilder used in concatenation
  • 6912 - [C#] Fix S1144 FP: Unused fields in class with StructLayout
  • 5521 - [C#] Fix S1643 FP: should not apply when strings are not aggregated
  • 3945 - [C#] Fix S3925 FP: Classes not having extra properties should not have to extend ISerializable interface

False Negative

  • 7688 - [C#] Fix S1125 FN: recognize C#9 "is not" constant pattern
  • 2619 - [C#] Fix S1125 FN: recognize "is" keyword with constant pattern
  • 7713 - [C#] Fix S1643 FN: consider simple assignments with variable not on the innermost add expression

Performance

  • 7664 - Allocations: Make IsUnchanged allocation free in the common case
  • 7663 - Allocations: Move stringliteral tokens array to static field
  • 7656 - Allocations: Remove delegate allocation from IsExcluded
  • 7655 - Allocations: Remove delegate allocation from IsGenerated
  • 7440 - Allocations: Unroll AdditionalFile extension method
  • 7439 - Allocations: Avoid capturing and delegate allocations in SonarAnalysisContextBase

9.6

This release introduces 3 new security-related rules for VB.NET and improves the precision of their existing C# versions by migrating them to the new symbolic execution engine. This version also includes a new code fix and fixes for false negative issues. Kudos to @​Corniel for his contribution by implementing a codefix for S125 (SonarSource/sonar-dotnet#313)

New Rules

  • 7560 - [VB.NET] New rule S2053: Hashes should include an unpredictable salt
  • 7562 - [VB.NET] New rule S3329: Cipher Block Chaining IVs should be unpredictable
  • 7565 - [VB.NET] New Rule S5773: Types allowed to be deserialized should be restricted

Improvements

  • 7424 - [VB.NET] Merge rule S2373 onto S119 (S2373 is now deprecated)
  • 313 - [C#] Rule S125: Add a code fix to remove the commented code

... (truncated)

Commits
  • d9025b5 Update RSPEC before 9.7 release (#7724)
  • 28c59a4 Reproducer for #7722 Concatenation for parameters, fields and properties are ...
  • b9bab9b Fix S1125 CodeFix: C# pattern matching in conditional operator (#7719)
  • 8f6674f Fix S1125 FN: recognize "is" and "is not" keyword with constant pattern (#7687)
  • 85c2441 Fix S3925 FP: Classes should need to opt-in for serialization (#7673)
  • 3144489 Fix S1643 FN: consider simple assignments with variable not on the innermost ...
  • d42e451 Deprecation: Replace ValidateTag with TagValue (BeTrue part) (#7705)
  • 23ddd7e Fix S1643 FP: should not apply when strings are not aggregated (#7711)
  • c58a860 Fix S4023 FP: Interfaces that provide type parameters from base interface (#7...
  • 4b25ebc Fix copy paste in S1186 docs (#7587)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.25.0.33663 to 9.7.0.75501.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@8.25.0.33663...9.7.0.75501)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cedbe94) 80.59% compared to head (4c1a609) 80.59%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           g11n-csharp-client    #2542   +/-   ##
===================================================
  Coverage               80.59%   80.59%           
===================================================
  Files                      45       45           
  Lines                    3169     3169           
  Branches                  382      382           
===================================================
  Hits                     2554     2554           
  Misses                    462      462           
  Partials                  153      153           
Flag Coverage Δ
unittests 80.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Aug 21, 2023

Superseded by #2574.

@dependabot dependabot bot closed this Aug 21, 2023
@dependabot dependabot bot deleted the dependabot/nuget/singletonclient/g11n-csharp-client/SonarAnalyzer.CSharp-9.7.0.75501 branch August 21, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants