Modifies canBeApproved to check if results are final and fix correspo…

…nding exception during approval
vocdoni · Feb 21, 2024 · 6985499 · 6985499
1 parent fc1e4be
commit 6985499
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/js-client/src/internal/modules/methods.ts b/packages/js-client/src/internal/modules/methods.ts
@@ -539,7 +539,9 @@ export class GaslessVotingClientMethods
     const proposal = await this.getProposal(proposalId);
     if (!proposal) return Promise.reject(new InvalidProposalIdError());
     if (!proposal.vochain?.tally?.final)
-      Promise.reject(Error('No results yet'));
+      return Promise.reject(
+        new Error('Gasless Proposals results are not yet available')
+      );
 
     if (proposal.approvers.length == 0) {
       return this.setTally(

diff --git a/packages/js-client/src/internal/utils.ts b/packages/js-client/src/internal/utils.ts
@@ -423,7 +423,7 @@ export function toNewProposal(
     },
     voters,
     approvers: proposal.approvers.map((x) => x.id.split('_')[1]),
-    canBeApproved: hasSucceeded,
+    canBeApproved: hasSucceeded && vochainProposal.finalResults,
   } as GaslessVotingProposal;
 }