Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new package: niri 0.1.10.1 #52794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

new package: niri 0.1.10.1 #52794

wants to merge 1 commit into from

Conversation

trolljoe
Copy link

@trolljoe trolljoe commented Oct 27, 2024

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

contains templates for the niri window manager. i added extra rustflags for musl as it will not compile without those (cannot check if the actual musl checking part works as of now, but i've tested and it only compiles by adding those flags)

closes #48456

@lukeflo
Copy link

lukeflo commented Oct 27, 2024

Hey, merged your PR in my personal Void-Packages fork. Build the package and successfully installed it. So far, everything works just fine. But you might add some post-install hooks:

  • Move the niri.desktop file to /usr/share/wayland-sessions. Otherwise, most display managers can't find niri as possible WM (at least in my case using emptty).
    • Change the Exec command inside the desktop file from niri-session to niri --session since the former isn't installed (and also not needed) through your workflow.
  • Move the niri.portals file to /usr/share/xdg-desktop-portal. Might be neccessary for working correct within the xdg system
  • Copy the default config.kdl either to /etc/niri/ or $XDG_CONFIG_HOME/niri/config.kdl so there are some default values as well as a template for editing the config file

Beside these few additions great work! niri looks really nice and has the potential to replace sway as my main tiling WM.

@trolljoe
Copy link
Author

trolljoe commented Oct 27, 2024

for the portals and desktop, i sadly could not get building with those being moved. i could add a vmkdir to make /usr/share/wayland-sessions and others but i don't know if that's allowed. for the default config, that shouldn't be needed, it automatically fetches config.kdl and adds it to .config.

edit: i have added some vmkdir to make the usr directories and i'm gonna try and build it again.

@lukeflo
Copy link

lukeflo commented Oct 28, 2024

Looks very good. Exactly the settings I also applied. Works flawlessly so far. Hopefully it will get merged soon, so it can be regularly used through xbps!

srcpkgs/niri/template Outdated Show resolved Hide resolved
srcpkgs/niri/template Outdated Show resolved Hide resolved
srcpkgs/niri/template Outdated Show resolved Hide resolved
@classabbyamp
Copy link
Member

you didn't push any of the fixes

@trolljoe
Copy link
Author

you didn't push any of the fixes

huh, don't know what happened, i'll try pushing them again later

srcpkgs/niri/template Outdated Show resolved Hide resolved
@lukeflo
Copy link

lukeflo commented Nov 8, 2024

Just built the niri package again with the added vinstall commands. Worked fine! All necessary files are placed in the correct dir.

Hope this PR gets merged soon since all checks have passed and its reviewed. If I can help test out anything which is holding it back from getting merged, just tell me.

Great work!

@vikigenius
Copy link
Contributor

Lol, there was just a new release today for 0.1.10. MIght as well update it, since this hasn't gotten merged yet anyways

@lukeflo
Copy link

lukeflo commented Nov 13, 2024

There is a bugfix for the current release: https://github.com/YaLTeR/niri/releases/tag/v0.1.10.1

Maybe worth adding to the PR

@trolljoe trolljoe changed the title new package: niri 0.1.10 new package: niri 0.1.10.1 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Niri
5 participants