Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicated dependencies in vs201x toolsets output #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid duplicated dependencies in vs201x toolsets output #106

wants to merge 1 commit into from

Commits on Apr 19, 2018

  1. Avoid duplicated dependencies in vs201x toolsets output 

    Although nobody would arguably duplicate the dependencies on purpose, it
was easy to do this unintentionally by inheriting a dependency from a
base template and also adding it explicitly -- and this, in fact,
happened in several places in real projects, resulting in not quite
correct solution and project files being generated: such files could
still be read by MSVS, but were rewritten by it to prune the duplicate
dependencies, resulting in changes compared to the originally generated
versions.

Avoid this by emitting the dependencies only once in both the solution
and the project files: this requires duplicating the duplication pruning
logic, but is better than trying to do it at the model level because the
dependencies may result from the evaluation of expressions involving the
toolset name and other variables, so this approach is much simpler to
make work.

Also add a unit test verifying that this now behaves as expected.
    @vadz
    vadz committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    87ad322 View commit details
    Browse the repository at this point in the history